Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(op-node): Finalize Mainnet Rollup Config [release branch] #5905

Merged
merged 3 commits into from
Jun 6, 2023

Conversation

refcell
Copy link
Contributor

@refcell refcell commented Jun 6, 2023

Description

Finalize the mainnet rollup config in the op-node chain config.

Checklist

  • Prestage (step 22.3)
  • Finalize (step 26)

@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2023

⚠️ No Changeset found

Latest commit: 8a2f037

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jun 6, 2023

Deploy Preview for opstack-docs ready!

Name Link
🔨 Latest commit b491312
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/647f646605ba3600085d0df0
😎 Deploy Preview https://deploy-preview-5905--opstack-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@refcell refcell changed the base branch from develop to release/bedrock-mainnet June 6, 2023 16:52
@refcell refcell self-assigned this Jun 6, 2023
@refcell refcell changed the title feat(op-node): Finalize Rollup Config Mainnet [release branch 2] feat(op-node): Finalize Rollup Config Mainnet [release branch] Jun 6, 2023
@refcell refcell changed the title feat(op-node): Finalize Rollup Config Mainnet [release branch] feat(op-node): Finalize Rollup Mainnet Config [release branch] Jun 6, 2023
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #5905 (b491312) into release/bedrock-mainnet (70c10eb) will decrease coverage by 2.72%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                     @@
##           release/bedrock-mainnet    #5905      +/-   ##
===========================================================
- Coverage                    42.19%   39.47%   -2.72%     
===========================================================
  Files                          453      295     -158     
  Lines                        29356    24695    -4661     
  Branches                       877        0     -877     
===========================================================
- Hits                         12386     9748    -2638     
+ Misses                       16013    14038    -1975     
+ Partials                       957      909      -48     
Flag Coverage Δ
bedrock-go-tests 39.47% <ø> (-0.06%) ⬇️
common-ts-tests ?
contracts-bedrock-tests ?
contracts-tests ?
core-utils-tests ?
dtl-tests ?
fault-detector-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-node/chaincfg/chains.go 100.00% <ø> (ø)

... and 160 files with indirect coverage changes

@refcell refcell changed the title feat(op-node): Finalize Rollup Mainnet Config [release branch] feat(op-node): Finalize Mainnet Rollup Config [release branch] Jun 6, 2023
@clabby clabby marked this pull request as ready for review June 6, 2023 17:33
@clabby clabby requested a review from a team as a code owner June 6, 2023 17:33
@clabby clabby merged commit d826cb0 into release/bedrock-mainnet Jun 6, 2023
@clabby clabby deleted the refcell/chain/doover branch June 6, 2023 17:33
keroro520 pushed a commit to keroro520/optimism that referenced this pull request Oct 20, 2023
* op-batcher: Add metrics for pending L2 transaction data size (ethereum-optimism#5797)

* feat(op-node): Finalize Mainnet Rollup Config [release branch] (ethereum-optimism#5905)

* copy over develop chainsgo

* stage rollup config changes

* final rollup config values

* fix(op-batcher): solve race condition of BatchSubmitter publishTxToL1 and handleReceipt access state concurrently (#5)

* chore: update readme, add testnet assets (ethereum-optimism#9)

* chore: update readme, add testnet assets

* doc: clarify readme

* ci: add the ci code used to package and release docker images (ethereum-optimism#11)

* ci: add the ci code used to package and release docker images (#7)

* ci: add the ci code used to package and release docker images

Co-authored-by: Welkin <[email protected]>

* fix: add latest tag for docker image (ethereum-optimism#9)

Co-authored-by: Welkin <[email protected]>

* try to use cache for docker build (ethereum-optimism#10)

Co-authored-by: Welkin <[email protected]>

---------

Co-authored-by: Welkin <[email protected]>

* feat(ci): add ci workflow

* fix

* fix

* update

* update

* skip fail test temporarily

* add batcher/proposer

* add e2e

* skip fail e2e case temporary

* add op-node-lint

* fix lint

* add batcher/proposer lint

* test junit-report

* add junit report for all

* adjust parallel to 2 for avoiding fail

* add needs for job serial execution

* use testname format to simplify result

---------

Co-authored-by: Joshua Gutow <[email protected]>
Co-authored-by: refcell.eth <[email protected]>
Co-authored-by: bnoieh <[email protected]>
Co-authored-by: Owen <[email protected]>
Co-authored-by: Welkin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants